thorn/jep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/jep-hack.git synced 2026-02-07 00:25:24 +13:00
Code Issues Projects Releases Packages Wiki Activity Actions

THE MOVESET AUDIT

Browse source
This commit is contained in:
Misty 2024-08-26 03:00:23 -04:00
parent 1a43922f29
commit 756f9a23de
16 changed files with 2725 additions and 2142 deletions
Download patch file Download diff file Expand all files Collapse all files

85
engine/pokemon/evolve.asm
View file

@ -291,7 +291,7 @@ EvolveAfterBattle_MasterLoop:
ld [wTempSpecies], a
xor a
ld [wMonType], a
call LearnEvolutionMove
; call LearnEvolutionMove
call LearnLevelMoves
ld a, [wTempSpecies]
call SetSeenAndCaughtMon
@ -357,49 +357,50 @@ EvolveAfterBattle_MasterLoop:
; BUG: Does not take in the designated move correctly, resulting in strange behaviour usually seen when GetMoveIDFromIndex takes an 8-bit index.
; Comments proceeding
LearnEvolutionMove:
ld a, [wTempSpecies]
ld [wCurPartySpecies], a
call GetPokemonIndexFromID
ld b, h
ld c, l
ld hl, EvolutionMoves
add hl, bc
add hl, bc
dec hl
dec hl
ld a, [hli]
ld h, [hl]
ld l, a ; Moves through the table by going up according to the Pokemon's ID, storing the equivalent move in hl. This is fine.
or h ; hl == 0?
ret z
; LearnEvolutionMove:
; ld a, [wTempSpecies]
; ld [wCurPartySpecies], a
; call GetPokemonIndexFromID
; ld b, h
; ld c, l
; ld hl, EvolutionMoves
; add hl, bc
; add hl, bc
; dec hl
; dec hl
; ld a, [hli]
; ld h, [hl]
; ld l, a ; Moves through the table by going up according to the Pokemon's ID, storing the equivalent move in hl. This is fine.
; or h ; hl == 0?
; ret z
call GetMoveIDFromIndex ; grabs what's in hl (the move) and converts it to 8-bit...or something like that. anyway, it should return in register a.
push hl ; I don't actually know why it does this. Removing it produces manmade horrors beyond my comprehension, so it isn't part of the current problem.
ld d, a ; preserve a
ld hl, wPartyMon1Moves
ld a, [wCurPartyMon]
ld bc, PARTYMON_STRUCT_LENGTH
call AddNTimes
ld b, NUM_MOVES
.check_move
ld a, [hli]
cp d ; use preserved a to check if a move is there
jr z, .has_move
dec b
jr nz, .check_move
ld a, d ; take the preserved a and reload
ld [wPutativeTMHMMove], a ; proceed to learn the move with adequate preprep
ld [wNamedObjectIndex], a
call GetMoveName
call CopyName1
predef LearnMove
ld a, [wCurPartySpecies]
ld [wTempSpecies], a
.has_move
pop hl
ret
; call GetMoveIDFromIndex ; grabs what's in hl (the move) and converts it to 8-bit...or something like that. anyway, it should return in register a.
; push hl ; I don't actually know why it does this. Removing it produces manmade horrors beyond my comprehension, so it isn't part of the current problem.
; ld d, a ; preserve a
; ld hl, wPartyMon1Moves
; ld a, [wCurPartyMon]
; ld bc, PARTYMON_STRUCT_LENGTH
; call AddNTimes
; ld b, NUM_MOVES
; .check_move
; ld a, [hli]
; cp d ; use preserved a to check if a move is there
; jr z, .has_move
; dec b
; jr nz, .check_move
; ld a, d ; take the preserved a and reload
; ld [wPutativeTMHMMove], a ; proceed to learn the move with adequate preprep
; ld [wNamedObjectIndex], a
; call GetMoveName
; call CopyName1
; predef LearnMove
; ld a, [wCurPartySpecies]
; ld [wTempSpecies], a
; .has_move
; pop hl
; ret
; so wtf is going on
UpdateSpeciesNameIfNotNicknamed:
ld a, [wCurSpecies]
push af