pokegear townmap shows correct region + doest OOB

This commit is contained in:
Thorn Avery 2023-10-28 04:35:47 +11:00
parent 3e6878efe6
commit ba3612713b
2 changed files with 31 additions and 17 deletions

5
.gitignore vendored
View file

@ -55,3 +55,8 @@ used_space.png
# macos files # macos files
.DS_STORE .DS_STORE
# nix files
result
.envrc
.direnv/*

View file

@ -540,12 +540,12 @@ Pokegear_UpdateClock:
PokegearMap_CheckRegion: PokegearMap_CheckRegion:
ld a, [wPokegearMapPlayerIconLandmark] ld a, [wPokegearMapPlayerIconLandmark]
cp LANDMARK_FAST_SHIP cp LANDMARK_SILVER_CAVE+1
jr z, .johto jr c, .johto
cp KANTO_LANDMARK cp LANDMARK_FAST_SHIP+1
jr nc, .kanto jr c, .kanto
cp NIHON_LANDMARK ;cp NIHON_LANDMARK
jr c, .nihon jp .nihon
.johto .johto
ld a, POKEGEARSTATE_JOHTOMAPINIT ld a, POKEGEARSTATE_JOHTOMAPINIT
jr .done jr .done
@ -752,13 +752,13 @@ TownMap_GetKantoLandmarkLimits:
ld a, [wStatusFlags] ld a, [wStatusFlags]
bit STATUSFLAGS_HALL_OF_FAME_F, a bit STATUSFLAGS_HALL_OF_FAME_F, a
jr z, .not_hof jr z, .not_hof
ld d, LANDMARK_ROUTE_28 ld d, LANDMARK_FAST_SHIP
ld e, LANDMARK_PALLET_TOWN ld e, LANDMARK_PALLET_TOWN
ret ret
.not_hof .not_hof
ld d, LANDMARK_ROUTE_28 ld d, LANDMARK_VICTORY_ROAD
ld e, LANDMARK_VICTORY_ROAD ld e, LANDMARK_PALLET_TOWN
ret ret
TownMap_GetNihonLandmarkLimits: TownMap_GetNihonLandmarkLimits:
@ -1572,7 +1572,7 @@ RadioChannels:
ld a, [wPokegearMapPlayerIconLandmark] ld a, [wPokegearMapPlayerIconLandmark]
cp LANDMARK_FAST_SHIP cp LANDMARK_FAST_SHIP
jr z, .johto jr z, .johto
cp KANTO_LANDMARK cp LANDMARK_SILVER_CAVE+1
jr c, .johto jr c, .johto
; kanto or nihon ; kanto or nihon
and a and a
@ -1925,10 +1925,19 @@ _TownMap:
.InitTilemap: .InitTilemap:
ld a, [wTownMapPlayerIconLandmark] ld a, [wTownMapPlayerIconLandmark]
cp NIHON_LANDMARK cp LANDMARK_SILVER_CAVE + 1
jr nc, .nihon2 jr c, .johto2
cp KANTO_LANDMARK cp LANDMARK_FAST_SHIP + 1
jr nc, .kanto2 jr c, .kanto2
jp .nihon2
;cp NIHON_LANDMARK
;jr nc, .nihon2
;cp KANTO_LANDMARK
;jr nc, .kanto2
;ld e, JOHTO_REGION
;jr .okay_tilemap
.johto2
ld e, JOHTO_REGION ld e, JOHTO_REGION
jr .okay_tilemap jr .okay_tilemap
@ -2052,15 +2061,15 @@ LoadStation_PokemonChannel:
PokegearMap: PokegearMap:
ld a, e ld a, e
and a cp JOHTO_REGION
jr nz, .kanto jr nz, .kanto
call LoadTownMapGFX call LoadTownMapGFX
call FillJohtoMap call FillJohtoMap
ret ret
.kanto .kanto
cp NIHON_LANDMARK cp KANTO_REGION
jr c, .nihon jr nz, .nihon
call LoadTownMapGFX call LoadTownMapGFX
call FillKantoMap call FillKantoMap
ret ret