This adds Rock Climb functionality to Strong Arm and Dive functionality to Water Sport, as discussed in the server. HMs have been added, but we need 16bit Items to add Wind Ride, and I haven't finished their functionality.
The Rock Climb tile is a bit terrible, it's not easy to notice. Maybe change so that it works well with yellow or another colour?
This does not build due to issues with effect_commands.asm, but since Zeta is meant to be working on the mapping and Water Sport anyway, it seems to be up his alley.
I ported over much of the underwater assets Rangi was using as they looked very pretty. I imagine it'll be fun to utilise going forward. May as well, right?
I shall now lay down in a dark room.
Review: c21561ea71 (diff-5508f3b794fc68821ba35e94b6a293b2aaaa16c02a1b34fac70d03fd2f74c4b2R113)
Had to split bank 2 because I ran out of unreferenced code to comment out when adding Aventurine
Fuchsia was pissing me off so I applied the changes from KEP when adding the safari zone graphics, though it's not currently super close to what it was like in LGPE
Aventurine is very early stages but it's in there :V
All tree variants now included in kanto maps, with an overhauled blue tree as opposed to the original because holy SHIT
Also Buoy graphics instead of Bollards in the middle of the ocean lol
- Bollards from Yellow
- Roof tiles from Yellow and Blue
- Trees and Signs from Green, Blue, and Yellow
- Improved roof shading
- Japanese PC Pokecenter Icon in Kanto tileset
- Oaks RBY lab design
- Some small amount of usage of new sign tiles in some Kanto maps
- Pewter City Museum roof finally doesn't have a crack in it
- also a fix for some messed up collision in silent hills lol
Required a little tinkering because I'm vain and wanted the door to be accurate. Please understand.
When doing Viridian Forest I had a bit of a moment and kept trying to use the entirely wrong building when it was staring me in the face. I am sorry.
I'm getting an 8-bit error on Mewtwo's object code in Cerulean Cave B1F. Misty may need to check this, I'm just getting these locations put in the overworld.