Implementing post-stream bug fixes

This addresses some issues found during my last KEP stream.
- Take Down TM on Silph 5F to Earthquake, ensuring that TM does not go unused.
- Bill's Garden now features Lapras and has level deviation.
- Mt. Moon B1F's area where you access Mt. Moon Square now uses an upward-facing ladder, giving the illusion of going to a summit-like location. This makes its current odd location make more sense while not invalidating the progression regular Mt. Moon has.
- Melanie should now give Bulbasaur correctly.
- The Karate Master now has a failsafe for if you got a Hitmon, where he is guaranteed to not refight you before the post-game.
- Fixed a 17 error Old Dance Jacket reported with the Up-Grade NPC's text.
- Fixed nickname screen corruption when getting the Pikachu/Eevee mode starters.
- Fixed some curious warp issues with Lavender Tower by reversing 3F. Could use with some tinkering. Silph still needs fixes.

Credits have also been made more precise in the interests of better open source derivatives. Felt a bit odd expanding my credits so much, but this also made me realise I need to touch grass more frequently. I have also made our Open Source policy more precise.
This commit is contained in:
Llinos Evans 2023-07-24 01:08:46 +01:00
parent 77261d1dd6
commit 07a71f2ab3
11 changed files with 56 additions and 46 deletions

View file

@ -291,9 +291,8 @@ DaycareMelanie:
call z, WaitForTextScrollButtonPress ; and here.
call EnableAutoTextBoxDrawing ; and here. it's very hasty.
ld a, [wObtainedBadges] ; load the badge count
bit BIT_CASCADEBADGE, a
jr z, .superDone ; no? d'oh! darn those brock skippers!
CheckEvent EVENT_BEAT_MISTY ; Beat Misty?
jr z, .superDone ; Didn't beat Misty? It's over. It's just over.
; If they picked any of the main 3 they can't get this.
ld a, [wPlayerStarter]
@ -311,7 +310,7 @@ DaycareMelanie:
ld a, [wCurrentMenuItem]
and a
jr nz, .refused ; imagine refusing a bulbasaur tbh
call SaveScreenTilesToBuffer1 ; prevents nickname screen corruption
lb bc, BULBASAUR, 12 ; load the bulbasaur
call GivePokemon ; attempt to give the bulbasaur
jr nc, .fullParty ; if it's fucked just go here

View file

@ -109,6 +109,8 @@ FightingDojoText1: ; gym scaling can be removed to make space
text_asm
CheckEvent EVENT_POST_GAME_ATTAINED ; No need to view previous stuff, technically you can skip Bide this way but I think that's hilarious
jp z, .normalProcessing
CheckEvent EVENT_GOT_HITMON ; failsafe
jp nz, .continue2
CheckEvent EVENT_DEFEATED_FIGHTING_DOJO
jp nz, .continue1
CheckEventReuseA EVENT_BEAT_KARATE_MASTER

View file

@ -290,6 +290,7 @@ Route24Damian:
ld a, [wCurrentMenuItem]
and a
jr nz, .asm_515d0
call SaveScreenTilesToBuffer1 ; prevents nickname screen corruption
ld a, CHARMANDER
ld [wd11e], a
ld [wcf91], a

View file

@ -447,6 +447,7 @@ OfficerJennySquirtle:
ld a, [wCurrentMenuItem]
and a
jr nz, .refuse
call SaveScreenTilesToBuffer1 ; prevents nickname screen corruption
ld a, SQUIRTLE
ld [wd11e], a
ld [wcf91], a