From 17d12a04135fefe1ea623cba8030cc2fcfbbe83c Mon Sep 17 00:00:00 2001 From: May Evans <36418502+PlagueVonKarma@users.noreply.github.com> Date: Thu, 8 Dec 2022 16:11:29 +0000 Subject: [PATCH] Faster health bar A simple 1-character change that does so much. Usually, the game delays it by 2 frames per pixel, so changing it to 1 doubles the speed. If it remains too slow, I believe it can be removed entirely, but I'm avoiding it in case of bugs. I also changed the debug Pokemon to Croakozuna as Pound is s/e vs Dark, allowing for an easier visual. Rhydon changed to Rhyperior for the same reason; more damage, better visual. --- README.md | 1 + engine/debug/debug_menu.asm | 6 +++--- engine/gfx/hp_bar.asm | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b9347321..e323e508 100644 --- a/README.md +++ b/README.md @@ -68,6 +68,7 @@ QoL Enhancements - All 217 (current) Pokemon can be obtained without the use of trading or glitches, including Mew! - New Pokedex entries for most Pokemon are available, sourced from the original 1996 Pokedex book by Creatures Inc., restoring a ton of old Kanto lore. Thanks to [Dr. Lava and Nob Ogasaware](http://lavacutcontent.com/1996-creatures-pokedex-translation-1/) for their incredible work translating and writing about it! - Fast text has no frame delay between text scrolling, doubling the scroll speed. It's also been made the default option, so you don't need to go into the Options menu for it. +- HP bar has been doubled in speed, having a 1 frame delay per pixel rather than 2. - Trainer DVs are perfect-15s. - The protagonist is referred to in a gender neutral manner. - PC added to Celadon Hotel where the invisible event usually is. Why not? diff --git a/engine/debug/debug_menu.asm b/engine/debug/debug_menu.asm index 61a77f2f..84f55cb4 100644 --- a/engine/debug/debug_menu.asm +++ b/engine/debug/debug_menu.asm @@ -90,8 +90,8 @@ TestBattle: ld [hl], a ; Give the player a - ; level 20 Rhydon. - ld a, RHYDON + ; level 20 Rhyperior. + ld a, RHYPERIOR ld [wcf91], a ld a, 20 ld [wCurEnemyLVL], a @@ -102,7 +102,7 @@ TestBattle: ; Fight against a ; level 20 Rhydon. - ld a, RHYDON + ld a, CROAKOZUNA ld [wCurOpponent], a predef InitOpponent diff --git a/engine/gfx/hp_bar.asm b/engine/gfx/hp_bar.asm index d848a337..c367853b 100644 --- a/engine/gfx/hp_bar.asm +++ b/engine/gfx/hp_bar.asm @@ -144,7 +144,7 @@ UpdateHPBar_AnimateHPBar: push de ld d, $6 call DrawHPBar - ld c, 2 + ld c, 1 ; was 2, this doubles hp bar speed call DelayFrames pop de ld a, [wHPBarDelta] ; +1 or -1