thorn/kep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/kep-hack.git synced 2026-02-06 15:45:24 +13:00
Code Issues Projects Releases Packages Wiki Activity Actions

Groundwork for Tradeback Move Tutor

Browse source 
Currently the move tutor is a little bit broken - the IDs are 1 above how they should be. Shell speculates that it's searching at the table starting from Kangaskhan due to the way the decrements shake up but it may just be making things more complicated than they are.

Big cheese code is `PrepareTradebackMoveList`, it's where things are mucking up.

Also, the code can be significantly optimised, as it's currently being adapted from the function above, `PrepareRelearnableMoveList`; It doesn't need to check levels, for example.

Note that the relearner functions properly, so use it as a reference. I may have removed something important.

Technically, we could have NO_MON as an entry which may make things shake out properly. But I'd rather have a proper fix.
This commit is contained in:
Llinos Evans 2023-04-23 06:11:05 +01:00
parent 5e21c159f9
commit 2f01628cd9
24 changed files with 1657 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

2
constants/map_constants.asm
View file

@ -183,7 +183,7 @@ DEF FIRST_INDOOR_MAP EQU const_value
map_const SEAFOAM_ISLANDS_B2F, 15, 9 ; $A1
map_const SEAFOAM_ISLANDS_B3F, 15, 9 ; $A2
map_const SEAFOAM_ISLANDS_B4F, 15, 9 ; $A3
map_const VERMILION_OLD_ROD_HOUSE, 4, 4 ; $A4 - Now unused
map_const CITRINE_TRADEBACK_HOUSE, 4, 4 ; $A4 - Was Vermillion Old Rod house
map_const FUCHSIA_GOOD_ROD_HOUSE, 4, 4 ; $A5
map_const POKEMON_MANSION_1F, 15, 14 ; $A6
map_const CINNABAR_GYM, 10, 9 ; $A7