thorn/kep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/kep-hack.git synced 2026-02-06 15:45:24 +13:00
Code Issues Projects Releases Packages Wiki Activity Actions

Groundwork for Tradeback Move Tutor

Browse source 
Currently the move tutor is a little bit broken - the IDs are 1 above how they should be. Shell speculates that it's searching at the table starting from Kangaskhan due to the way the decrements shake up but it may just be making things more complicated than they are.

Big cheese code is `PrepareTradebackMoveList`, it's where things are mucking up.

Also, the code can be significantly optimised, as it's currently being adapted from the function above, `PrepareRelearnableMoveList`; It doesn't need to check levels, for example.

Note that the relearner functions properly, so use it as a reference. I may have removed something important.

Technically, we could have NO_MON as an entry which may make things shake out properly. But I'd rather have a proper fix.
This commit is contained in:
Llinos Evans 2023-04-23 06:11:05 +01:00
parent 5e21c159f9
commit 2f01628cd9
24 changed files with 1657 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

1
data/maps/objects/CitrineCity.asm
View file

@ -3,6 +3,7 @@ CitrineCity_Object:
def_warp_events
warp_event 9, 27, CITRINE_ROCKET_HOUSE, 1
warp_event 9, 17, CITRINE_TRADEBACK_HOUSE, 1
def_bg_events

15
data/maps/objects/CitrineTradebackHouse.asm Normal file
View file

@ -0,0 +1,15 @@
CitrineTradebackHouse_Object:
db $a ; border block
def_warp_events
warp_event 2, 7, LAST_MAP, 2
warp_event 3, 7, LAST_MAP, 2
def_bg_events
def_object_events
object_event 2, 4, SPRITE_GAMBLER, STAY, RIGHT, 1 ; person
object_event 5, 4, SPRITE_COOLTRAINER_M, STAY, LEFT, 2 ; person
object_event 4, 3, SPRITE_PAPER, STAY, DOWN, 3 ; person
def_warps_to CITRINE_TRADEBACK_HOUSE

4
data/maps/objects/Route25.asm
View file

@ -2,11 +2,11 @@ Route25_Object:
db $2c ; border block
def_warp_events
warp_event 49, 11, BILLS_HOUSE, 1
warp_event 49, 5, BILLS_HOUSE, 1
warp_event 60, 1, UNDERWATER_TUNNEL, 1
def_bg_events
bg_event 53, 11, 11 ; Route25Text11
bg_event 51, 7, 11 ; Route25Text11
def_object_events
object_event 14, 2, SPRITE_YOUNGSTER, STAY, DOWN, 1, OPP_YOUNGSTER, 5

13
data/maps/objects/VermilionOldRodHouse.asm
View file

@ -1,13 +0,0 @@
VermilionOldRodHouse_Object:
db $a ; border block
def_warp_events
warp_event 2, 7, LAST_MAP, 9
warp_event 3, 7, LAST_MAP, 9
def_bg_events
def_object_events
object_event 2, 4, SPRITE_FISHING_GURU, STAY, RIGHT, 1 ; person
def_warps_to VERMILION_OLD_ROD_HOUSE