thorn/kep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/kep-hack.git synced 2026-02-06 23:55:24 +13:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor Item Constants

Browse source 
Alright, never put items after the floors. This is very, very bad, as it actually causes a myriad of problems whenever the game tries to assert the item list on its lonesome. Effectively, this has been adding floors. This caused the item descriptions to be offset by 21 spaces once you get to the TMs. The fact it worked before was a miracle.

Anyway, all considerations have been made when doing this, so it should all be just fine.

If you need to test if the items are ok, check the Up-Grade on Porygon, as it's the last in the list. Checks showed it was ok for me.

Also, Old Sea Chart now uses the localised name - Old Sea Map. This actually fits in-game, which is good.
This commit is contained in:
Llinos Evans 2023-04-09 12:25:10 +01:00
parent 374756eec6
commit 3f6005f3f1
10 changed files with 73 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

32
engine/menus/item_descriptions.asm
View file

@ -180,34 +180,6 @@ ItemDescriptionPointers:
text_end
text_far _MaxElixerDescription
text_end
text_far _UnusedItemDescription ; for the floor items - we've added items after these, so we need to stuff them in lest TM descriptions invade our personal space.
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end
text_far _UnusedItemDescription
text_end ; floor items end here
text_far _IceStoneDescription
text_end
text_far _ProtectorDescription
@ -220,7 +192,9 @@ ItemDescriptionPointers:
text_end
text_far _CitrinePassDescription
text_end
text_far _OldSeaChartDescription
text_far _OldSeaMapDescription
text_end
text_far _UpGradeDescription
text_end
text_far _HM01Description
text_end