From 4669dbc53ad4878d974f06d492610a64c6cd035e Mon Sep 17 00:00:00 2001 From: May Evans <36418502+PlagueVonKarma@users.noreply.github.com> Date: Tue, 4 Apr 2023 19:28:02 +0100 Subject: [PATCH] Extra trainer classes, new bold P I changed the P image to match the font used in the prototype assets. Also, because Yujirou has a pic all alone in that one bank, I added the other 4 beta trainer classes that never got used. They're all ready to be used, just need teams and a place to go, but I want to address trainer line-ups last code-wise. --- constants/trainer_constants.asm | 4 ++++ data/trainers/ai_pointers.asm | 6 +++++- data/trainers/move_choices.asm | 6 +++++- data/trainers/names.asm | 4 ++++ data/trainers/parties.asm | 12 ++++++++++++ data/trainers/pic_pointers_money.asm | 6 +++++- gfx/font/P.png | Bin 77 -> 151 bytes gfx/pics.asm | 6 +++++- gfx/trainers/firefighter.png | Bin 0 -> 891 bytes gfx/trainers/jack.png | Bin 0 -> 807 bytes gfx/trainers/junior.png | Bin 0 -> 645 bytes gfx/trainers/student.png | Bin 0 -> 718 bytes main.asm | 3 +-- scan_includes.exe.stackdump | 17 ++++++++--------- 14 files changed, 49 insertions(+), 15 deletions(-) create mode 100644 gfx/trainers/firefighter.png create mode 100644 gfx/trainers/jack.png create mode 100644 gfx/trainers/junior.png create mode 100644 gfx/trainers/student.png diff --git a/constants/trainer_constants.asm b/constants/trainer_constants.asm index 607a8a38..18038cf6 100644 --- a/constants/trainer_constants.asm +++ b/constants/trainer_constants.asm @@ -62,4 +62,8 @@ ENDM trainer_const AGATHA ; $2E trainer_const LANCE ; $2F trainer_const YUJIROU ; $0D, was unused juggler, also not 0D but I can't be bothered to change everything + trainer_const STUDENT + trainer_const FIREFIGHTER + trainer_const JUNIOR + trainer_const JACK DEF NUM_TRAINERS EQU const_value - 1 diff --git a/data/trainers/ai_pointers.asm b/data/trainers/ai_pointers.asm index a2c6975b..9b3e53e4 100644 --- a/data/trainers/ai_pointers.asm +++ b/data/trainers/ai_pointers.asm @@ -16,7 +16,6 @@ TrainerAIPointers: dbw 3, GenericAI dbw 3, GenericAI dbw 3, GenericAI - dbw 3, JugglerAI ; unused_juggler dbw 3, GenericAI dbw 3, GenericAI dbw 3, GenericAI @@ -51,4 +50,9 @@ TrainerAIPointers: dbw 3, GenericAI dbw 2, AgathaAI ; agatha dbw 1, LanceAI ; lance + dbw 3, GenericAI ; Yujirou + dbw 3, GenericAI ; Student + dbw 3, GenericAI ; Firefighter + dbw 3, GenericAI ; Junior + dbw 2, BlackbeltAI ; Jack assert_table_length NUM_TRAINERS diff --git a/data/trainers/move_choices.asm b/data/trainers/move_choices.asm index d943a1da..d2b570e9 100644 --- a/data/trainers/move_choices.asm +++ b/data/trainers/move_choices.asm @@ -21,7 +21,6 @@ TrainerClassMoveChoiceModifications: move_choices 1 ; BIKER move_choices 1, 3 ; BURGLAR move_choices 1 ; ENGINEER - move_choices 1, 3, ; UNUSED_JUGGLER move_choices 1, 3 ; FISHER move_choices 1, 3 ; SWIMMER move_choices ; CUE_BALL @@ -56,4 +55,9 @@ TrainerClassMoveChoiceModifications: move_choices 1 ; CHANNELER move_choices 1 ; AGATHA move_choices 1, 3 ; LANCE + move_choices 1, 3, ; YUJIROU, was UNUSED_JUGGLER + move_choices 1, 3, ; STUDENT + move_choices 1, 3, ; FIREFIGHTER + move_choices 1, 3, ; JUNIOR + move_choices 1, 3, ; JACK assert_list_length NUM_TRAINERS diff --git a/data/trainers/names.asm b/data/trainers/names.asm index 861abcfd..07d69ef7 100644 --- a/data/trainers/names.asm +++ b/data/trainers/names.asm @@ -46,3 +46,7 @@ TrainerNames:: db "AGATHA@" db "LANCE@" db "YUJIROU@" + db "STUDENT@" + db "FIREFIGHTER@" + db "JUNIOR@" + db "JACK@" diff --git a/data/trainers/parties.asm b/data/trainers/parties.asm index 06d9d0c1..38f240b7 100644 --- a/data/trainers/parties.asm +++ b/data/trainers/parties.asm @@ -46,6 +46,10 @@ TrainerDataPointers: dw AgathaData dw LanceData dw YujirouData ; was unused juggler + dw StudentData + dw FirefighterData + dw JuniorData + dw JackData ; if first byte != $FF, then ; first byte is level (of all pokemon on this team) @@ -858,3 +862,11 @@ YujirouData: ; was unused juggler db $FF, 7, KONYA, 7, RATTATA, 10, LICKITUNG, 0 ; post-game rematch team (currently unused) db $FF, 66, PERSIAN, 67, TAUROS, 67, MADAAMU, 66, BLISSEY, 67, SNORLAX, 70, LICKILICKY, 0 + +StudentData: + +FirefighterData: + +JuniorData: + +JackData: diff --git a/data/trainers/pic_pointers_money.asm b/data/trainers/pic_pointers_money.asm index 6e6d8fb6..9dd434bd 100644 --- a/data/trainers/pic_pointers_money.asm +++ b/data/trainers/pic_pointers_money.asm @@ -20,7 +20,7 @@ TrainerPicAndMoneyPointers:: pic_money BurglarPic, 9000 pic_money EngineerPic, 5000 pic_money FisherPic, 3500 - pic_money SwimmerPic, 500 + pic_money SwimmerPic, 1500 pic_money CueBallPic, 2500 pic_money GamblerPic, 7000 pic_money BeautyPic, 7000 @@ -54,4 +54,8 @@ TrainerPicAndMoneyPointers:: pic_money AgathaPic, 9900 pic_money LancePic, 9900 pic_money YujirouPic, 9900 ; was unused juggler + pic_money StudentPic, 1000 + pic_money FirefighterPic, 1500 + pic_money JuniorPic, 1000 + pic_money JackPic, 5000 assert_table_length NUM_TRAINERS diff --git a/gfx/font/P.png b/gfx/font/P.png index 3df11133d89e650eb6ffb323e9b8b2464a6c0750..01d8f8f5b34eea1125f0acaeecf7549eca90984b 100644 GIT binary patch delta 133 zcmeaB&NxA$o`a2nf#C@MzHT7JSRCZ;#IWw1%u67LCEd~2k%3`jKlh(RRv@3Vz$3Dl zfr0M`2s2LA=92~r>Ug?1hG+yQ|KVrhsbCPEa*R`=QDQZxLGwed3AsrrES%0qIHDYt e%@r7!nHhdu6#HR$x`_p-kHOQ`&t;ucLK6Vu{v(b6 delta 59 zcmbQv=sQ8el#u}l-jp<}0Vxqr7sn8e>&ZXPA2^f1*>;BK8_zceF*7FpoZSC`Aa$Ou KelF{r5}E)REfVhl diff --git a/gfx/pics.asm b/gfx/pics.asm index ba078c90..64452426 100644 --- a/gfx/pics.asm +++ b/gfx/pics.asm @@ -550,4 +550,8 @@ MissingNoPicFront:: INCBIN "gfx/pokemon/front/missingno.pic" MissingNoPicBack:: INCBIN "gfx/pokemon/back/missingnob.pic" SECTION "Pics 10", ROMX ; Extra Trainer Bank -YujirouPic:: INCBIN "gfx/trainers/yujirou.pic" \ No newline at end of file +YujirouPic:: INCBIN "gfx/trainers/yujirou.pic" +StudentPic:: INCBIN "gfx/trainers/student.pic" +FirefighterPic:: INCBIN "gfx/trainers/firefighter.pic" +JuniorPic:: INCBIN "gfx/trainers/junior.pic" +JackPic:: INCBIN "gfx/trainers/jack.pic" diff --git a/gfx/trainers/firefighter.png b/gfx/trainers/firefighter.png new file mode 100644 index 0000000000000000000000000000000000000000..f0a3617bb0e42cbc6d93d1c92494c77ae72891ef GIT binary patch literal 891 zcmV->1BCpEP) zdN=MQ+FGl%W`|m9YwgX=b0pwXQYq!SuJJ}Wmr^F1wAS89F29#6R3Ffp=Q?M}shmT4 zIV9RzE2U7Q{t}lgb@rI+nka=qUd~ykYOV7d_gkHD4H2CH`kpT^U$zcLtPhuShEYT+;{9>Vzo77-OBVIlF6vlYrlQH?k350gUL)PV8h) z>Ku@IT^E1q6c^|x*QeLExRh(~uGgzzx*ecl$hhNyF|4oN-?HJsk=}c)72j*E#@m=I z5Hxm)t~GjHm&x_25~IZlG!7hSG?XM5J1LI}n-DdJfkrtvtQlsA7_uq=UQ$Zwz0=Lr z<&kXply^t(lo6~~1B!^I!z8XzDSbm< zPZ>seOHVSS-(eXg%IHmFh06ykODulXX$7%uqmai)=~tSz&J<1QMM7R88lE(iGS>JP zC(KNSw~ioOd==63Y>wn=Xle5_;p#))ZA85}Y6-`hTFFhg(!}p4+DDC!MgUEcX%sJ& zE3(>_rEXlk=c>l)-QORKTo2rT`^DPC22h@Ay)tzZ5@)=pU{9@OHw7!IhRy7NVNBEYB*TdT8*g3afnE3?KqB1*^eg^ zb5)jnt1N4+NtSVIa-pCRo?)x`{GZF8DJKQ~&SaGwuFm=WWoULlF{?8Be@@H9}M-Kdw-m zhq+9<3%-0h5W4($+jz9rc!7dnxDpr^-ZBB(NN~LVP$RXw=1m8Q8e_^{hjA&@Fospd}<>aR`fwIp_Se) zT{j#%&W(Fa8-HA9bPXOmY7X5kFCMsxv!BI@&bVB$UvdqXRX5QUITho4hN@j)_)n#S z3uhPu(bo;o9VeIRNDGC5^$q*@9HI!VoxO_sT+b1Pie0K_Jr-WPN#& zG_6=wG;(AhB9A%b)77PlS5CzP-NhN+$K8qKB6>%cznMJay;58{==H7b_t-G&u9_vKmt=@a@9V-(m{>(BmJqj2IbMQL|m2R-tkdZ*GlT?Z#~TW>p?PI zeay^%iiAoj2>r57Jso=I0TESIWP;a_I}%TVE<8;ofDw@3!q(dSNzxqK=HbgUrYW#V zQ+sjMN87P4*`zPhakEGn;~^rgwHSS{PucutB5k8zpuBQfnpr|qGU}zTTV99H7L&7y zO78Xa@MHS~$cV^s7m{V-X6RCu{uod6!sD{#j^9X+P7u|KG{kx|*=JK+7<&FdcLydM z59>WzA#G8bd`2dHe^URi3caeH_xC9<;W(l=ZcZ99zA2fw;2+7;=t9{GdP;YaFm^o3 zMRfk;ao%yEj;bo!sFWTmlW3gm0g1JrNp$3ts8DQFJfFc2kL=(Jf;AGJ00000NkvXXu0mjfIAJ&E literal 0 HcmV?d00001 diff --git a/gfx/trainers/student.png b/gfx/trainers/student.png new file mode 100644 index 0000000000000000000000000000000000000000..d4120cc8161b7610415d68cf3712109a30bfc3dd GIT binary patch literal 718 zcmV;<0x|uGP)@>0gjIwo+2XERg9un zH@mSt3NzPQ@uyC@>UzZ~h3obZmL>Qp-7Bv45jTo#8h$C?kF?h2r3vZ-T5Br28-Ajt zl;yj7?{hz%a$|4T58}~TKi&Sl_XwdYgoxH!VL-M$b6u{7J#4LLd%w2nuzlMjlTQs^ z;eeB<&hiz}*-a&EQhRHBxs$Lib$;>FFx}Dp{Gsp7);9c*r1v?_0e>J4l}X~0Er(O_#QVt;}fDm ze~3xSFBsp)H^oK8L|gshCT|f{R6iBLQ?1~UaG&zII@F+RuBZu$0uT}wn}{5u*h!Wv z)r4WUjSFm*+|7(JlgoHzma6jKe?_f{17?xfbJ7Mdy z^pU~U={OiI<&<+(!mX%>D1aB=lYkt%y7-CCGYfuKa>`2-z2bT!)m)(bC8A5N@jD+O zD(7;;jZX6s%F8o5!=Et}BHiQUr#TPd&;0Yt7pPUCSyPc%kpKVy07*qoM6N<$f+@sP AQ~&?~ literal 0 HcmV?d00001 diff --git a/main.asm b/main.asm index 0e70bff2..4173dcd7 100644 --- a/main.asm +++ b/main.asm @@ -236,7 +236,7 @@ SECTION "Battle Engine 8", ROMX INCLUDE "engine/battle/init_battle_variables.asm" INCLUDE "engine/battle/move_effects/paralyze.asm" - +INCLUDE "engine/battle/experience.asm" ; moved because trainer ai grew too big SECTION "Hidden Objects 2", ROMX @@ -249,7 +249,6 @@ INCLUDE "engine/events/hidden_objects/indigo_plateau_hq.asm" SECTION "Battle Engine 9", ROMX -INCLUDE "engine/battle/experience.asm" INCLUDE "engine/battle/scroll_draw_trainer_pic.asm" INCLUDE "engine/battle/trainer_ai.asm" INCLUDE "engine/battle/draw_hud_pokeball_gfx.asm" diff --git a/scan_includes.exe.stackdump b/scan_includes.exe.stackdump index e821360a..a2642ae0 100644 --- a/scan_includes.exe.stackdump +++ b/scan_includes.exe.stackdump @@ -1,16 +1,15 @@ Exception: STATUS_ACCESS_VIOLATION at rip=00100401246 -rax=FFFFFFF7FFF97021 rbx=00000000000006AD rcx=0000000800000010 -rdx=0000000000000000 rsi=000000080005895E rdi=0000000000000000 -r8 =00000000FFFFC7C4 r9 =0000000000000000 r10=0000000100000000 -r11=0000000100401282 r12=0000000800068FE0 r13=0000000100403148 -r14=0000000000000000 r15=0000000000000001 -rbp=0000000100403156 rsp=00000000FFFFCA60 -program=C:\cygwin64\home\chipp\kep-hack\tools\scan_includes.exe, pid 1123, thread main +rax=FFFFFFF7FFFA7851 rbx=0000000000007D5E rcx=0000000800000010 +rdx=0000000000000000 rsi=0000000180369F60 rdi=0000000000000000 +r8 =00000000FFFFC844 r9 =0000000000000000 r10=0000000100000000 +r11=0000000100401282 r12=00000008000587B0 r13=0000000100403148 +r14=0000000000000018 r15=0000000000000001 +rbp=0000000100403156 rsp=00000000FFFFCAE0 +program=C:\cygwin64\home\chipp\kep-hack\tools\scan_includes.exe, pid 521, thread main cs=0033 ds=002B es=002B fs=0053 gs=002B ss=002B Stack trace: Frame Function Args -00100403156 00100401246 (0080005895E, 00000000022, 00100403166, 000FFFFCB90) -00100403156 00100401409 (00000000000, 00100000001, 00180227860, 00100407000) +00100403156 00100401246 (00000000000, 00100000001, 00180227860, 00100407000) 00100403178 00100401C87 (00000000020, 00000000000, 00180049B11, 00180048A70) 000FFFFCD30 00180049B7D (00000000000, 00000000000, 00000000000, 00000000000) 000FFFFFFF0 00180047746 (00000000000, 00000000000, 00000000000, 00000000000)