mirror of
https://github.com/thornAvery/kep-hack.git
synced 2025-09-17 02:40:50 +12:00
It’s official: if something needs doing, mark it with XXX.
If you’re not absolutely, positively sure a comment is correct, mark it with XXX. Don’t leave anything that’s not 100% clear unmarked, or nobody will ever fix it. hg-commit-id: 8d23e2ad71eb
This commit is contained in:
parent
ec8413e317
commit
4cccc2fdf8
|
@ -2420,8 +2420,8 @@ ReadTrainer: ; 5C53
|
||||||
ret nz
|
ret nz
|
||||||
|
|
||||||
; set [W_ENEMYMONCOUNT] to 0, [$D89D] to FF
|
; set [W_ENEMYMONCOUNT] to 0, [$D89D] to FF
|
||||||
; first is total enemy pokemon?
|
; XXX first is total enemy pokemon?
|
||||||
; second is species of first pokemon?
|
; XXX second is species of first pokemon?
|
||||||
ld hl,W_ENEMYMONCOUNT
|
ld hl,W_ENEMYMONCOUNT
|
||||||
xor a
|
xor a
|
||||||
ld [hli],a
|
ld [hli],a
|
||||||
|
@ -2468,7 +2468,7 @@ ReadTrainer: ; 5C53
|
||||||
ld a,[hli]
|
ld a,[hli]
|
||||||
and a ; have we reached the end of the trainer data?
|
and a ; have we reached the end of the trainer data?
|
||||||
jr z,.FinishUp\@
|
jr z,.FinishUp\@
|
||||||
ld [$CF91],a ; write species somewhere (why?)
|
ld [$CF91],a ; write species somewhere (XXX why?)
|
||||||
ld a,1
|
ld a,1
|
||||||
ld [$CC49],a
|
ld [$CC49],a
|
||||||
push hl
|
push hl
|
||||||
|
@ -2555,7 +2555,7 @@ ReadTrainer: ; 5C53
|
||||||
.GiveStarterMove\@
|
.GiveStarterMove\@
|
||||||
ld a,b
|
ld a,b
|
||||||
ld [W_ENEMYMON6MOVE3],a
|
ld [W_ENEMYMON6MOVE3],a
|
||||||
.FinishUp\@ ; this needs documenting
|
.FinishUp\@ ; XXX this needs documenting
|
||||||
xor a ; clear D079-D07B
|
xor a ; clear D079-D07B
|
||||||
ld de,$D079
|
ld de,$D079
|
||||||
ld [de],a
|
ld [de],a
|
||||||
|
|
Loading…
Reference in a new issue