thorn/kep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/kep-hack.git synced 2025-09-17 02:40:50 +12:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve NPC trade labels and comments (#384)

Browse source 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
This commit is contained in:
SatoMew 2022-09-10 18:44:31 +01:00 committed by GitHub
parent bbb0e7e82d
commit 63a7eb2cf5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
constants/script_constants.asm
View file

@ -22,7 +22,7 @@ DEF SLOTS_SOMEONESKEYS EQU $ff
const_def const_def
const TRADE_FOR_TERRY const TRADE_FOR_TERRY
const TRADE_FOR_MARCEL const TRADE_FOR_MARCEL
const TRADE_FOR_CHIKUCHIKU const TRADE_FOR_CHIKUCHIKU ; unused
const TRADE_FOR_SAILOR const TRADE_FOR_SAILOR
const TRADE_FOR_DUX const TRADE_FOR_DUX
const TRADE_FOR_MARC const TRADE_FOR_MARC
@ -36,7 +36,7 @@ DEF NUM_NPC_TRADES EQU const_value
; InGameTradeTextPointers indexes (see engine/events/in_game_trades.asm) ; InGameTradeTextPointers indexes (see engine/events/in_game_trades.asm)
const_def const_def
const TRADE_DIALOGSET_CASUAL const TRADE_DIALOGSET_CASUAL
const TRADE_DIALOGSET_POLITE const TRADE_DIALOGSET_EVOLUTION
const TRADE_DIALOGSET_HAPPY const TRADE_DIALOGSET_HAPPY
; badges ; badges

10
data/events/trades.asm
View file

@ -2,14 +2,18 @@ TradeMons:
; entries correspond to TRADE_FOR_* constants ; entries correspond to TRADE_FOR_* constants
table_width 3 + NAME_LENGTH, TradeMons table_width 3 + NAME_LENGTH, TradeMons
; give mon, get mon, dialog id, nickname ; give mon, get mon, dialog id, nickname
; The two instances of TRADE_DIALOGSET_EVOLUTION are a leftover
; from the Japanese Blue trades, which used species that evolve.
; Japanese Red and Green used TRADE_DIALOGSET_CASUAL, and had
; the same species as English Red and Blue.
db NIDORINO, NIDORINA, TRADE_DIALOGSET_CASUAL, "TERRY@@@@@@" db NIDORINO, NIDORINA, TRADE_DIALOGSET_CASUAL, "TERRY@@@@@@"
db ABRA, MR_MIME, TRADE_DIALOGSET_CASUAL, "MARCEL@@@@@" db ABRA, MR_MIME, TRADE_DIALOGSET_CASUAL, "MARCEL@@@@@"
db BUTTERFREE, BEEDRILL, TRADE_DIALOGSET_HAPPY, "CHIKUCHIKU@" db BUTTERFREE, BEEDRILL, TRADE_DIALOGSET_HAPPY, "CHIKUCHIKU@" ; unused
db PONYTA, SEEL, TRADE_DIALOGSET_CASUAL, "SAILOR@@@@@" db PONYTA, SEEL, TRADE_DIALOGSET_CASUAL, "SAILOR@@@@@"
db SPEAROW, FARFETCHD, TRADE_DIALOGSET_HAPPY, "DUX@@@@@@@@" db SPEAROW, FARFETCHD, TRADE_DIALOGSET_HAPPY, "DUX@@@@@@@@"
db SLOWBRO, LICKITUNG, TRADE_DIALOGSET_CASUAL, "MARC@@@@@@@" db SLOWBRO, LICKITUNG, TRADE_DIALOGSET_CASUAL, "MARC@@@@@@@"
db POLIWHIRL, JYNX, TRADE_DIALOGSET_POLITE, "LOLA@@@@@@@" db POLIWHIRL, JYNX, TRADE_DIALOGSET_EVOLUTION, "LOLA@@@@@@@"
db RAICHU, ELECTRODE, TRADE_DIALOGSET_POLITE, "DORIS@@@@@@" db RAICHU, ELECTRODE, TRADE_DIALOGSET_EVOLUTION, "DORIS@@@@@@"
db VENONAT, TANGELA, TRADE_DIALOGSET_HAPPY, "CRINKLES@@@" db VENONAT, TANGELA, TRADE_DIALOGSET_HAPPY, "CRINKLES@@@"
db NIDORAN_M, NIDORAN_F, TRADE_DIALOGSET_HAPPY, "SPOT@@@@@@@" db NIDORAN_M, NIDORAN_F, TRADE_DIALOGSET_HAPPY, "SPOT@@@@@@@"
assert_table_length NUM_NPC_TRADES assert_table_length NUM_NPC_TRADES