Fix a bunch of single player battle engine bugs

went through a bunch of the tutorials here;
https://github.com/pret/pokered/wiki/Bugs-and-Glitches#blaine-uses-super-potion-even-when-his-pok%C3%A9mon-arent-below-10-health

Overall:
- Blaine is no longer addicted to Super Potions
- CoolTrainerF no longer switches a lot
- Transformed Pokemon aren't presumed to be Dittos (very important given Animon)
- Status curing items don't remove modifiers anymore
- Learning new moves plays the sound in the correct bank
This commit is contained in:
May Evans 2022-08-31 14:42:36 +01:00
parent cab111d01b
commit 7c6bbb630f
3 changed files with 37 additions and 7 deletions

View file

@ -205,12 +205,38 @@ TryingToLearnText:
text_far _TryingToLearnText
text_end
OneTwoAndText:
OneTwoAndText: ; uses the fixed move swap sound - PvK
text_far _OneTwoAndText
text_pause
text_asm
text_far _OneTwoAndText
text_pause
text_asm
push af
push bc
push de
push hl
ld a, $1
ld [wMuteAudioAndPauseMusic], a
call DelayFrame
ld a, [wAudioROMBank]
push af
ld a, BANK(SFX_Swap_1)
ld [wAudioROMBank], a
ld [wAudioSavedROMBank], a
call WaitForSoundToFinish
ld a, SFX_SWAP
call PlaySoundWaitForCurrent
call PlaySound
call WaitForSoundToFinish
pop af
ld [wAudioROMBank], a
ld [wAudioSavedROMBank], a
xor a
ld [wMuteAudioAndPauseMusic], a
pop hl
pop de
pop bc
pop af
ld hl, PoofText
ret