From ac7263b1adef941f8978b775d4b7629a7d8620e3 Mon Sep 17 00:00:00 2001 From: SatoMew Date: Fri, 12 Aug 2022 02:22:57 +0100 Subject: [PATCH] Update comments related to Swift and Substitute checks (#380) Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com> --- engine/battle/core.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/battle/core.asm b/engine/battle/core.asm index 44c657ee..6aa697c9 100644 --- a/engine/battle/core.asm +++ b/engine/battle/core.asm @@ -5368,10 +5368,10 @@ MoveHitTest: .swiftCheck ld a, [de] cp SWIFT_EFFECT - ret z ; Swift never misses (interestingly, Azure Heights lists this is a myth, but it appears to be true) + ret z ; Swift never misses (this was fixed from the Japanese versions) call CheckTargetSubstitute ; substitute check (note that this overwrites a) jr z, .checkForDigOrFlyStatus -; This code is buggy. It's supposed to prevent HP draining moves from working on substitutes. +; The fix for Swift broke this code. It's supposed to prevent HP draining moves from working on Substitutes. ; Since CheckTargetSubstitute overwrites a with either $00 or $01, it never works. cp DRAIN_HP_EFFECT jp z, .moveMissed