Gave the labels in _MoveMon more descriptive names and added a few comments

This commit is contained in:
Joe Farebrother 2017-03-19 20:35:40 +00:00
parent caa146a298
commit ce35f2f7a1

View file

@ -340,13 +340,14 @@ _AddEnemyMonToPlayerParty:
_MoveMon: _MoveMon:
ld a, [wMoveMonType] ld a, [wMoveMonType]
and a and a ; BOX_TO_PARTY
jr z, .checkPartyMonSlots jr z, .checkPartyMonSlots
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
jr z, .checkPartyMonSlots jr z, .checkPartyMonSlots
cp PARTY_TO_DAYCARE cp PARTY_TO_DAYCARE
ld hl, wDayCareMon ld hl, wDayCareMon
jr z, .asm_f575 jr z, .findMonDataSrc
; else it's PARTY_TO_BOX
ld hl, wNumInBox ld hl, wNumInBox
ld a, [hl] ld a, [hl]
cp MONS_PER_BOX cp MONS_PER_BOX
@ -369,24 +370,26 @@ _MoveMon:
ld a, [wMoveMonType] ld a, [wMoveMonType]
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
ld a, [wDayCareMon] ld a, [wDayCareMon]
jr z, .asm_f556 jr z, .copySpecies
ld a, [wcf91] ld a, [wcf91]
.asm_f556 .copySpecies
ld [hli], a ; write new mon ID ld [hli], a ; write new mon ID
ld [hl], $ff ; write new sentinel ld [hl], $ff ; write new sentinel
.findMonDataDest
ld a, [wMoveMonType] ld a, [wMoveMonType]
dec a dec a
ld hl, wPartyMons ld hl, wPartyMons
ld bc, wPartyMon2 - wPartyMon1 ; $2c ld bc, wPartyMon2 - wPartyMon1 ; $2c
ld a, [wPartyCount] ld a, [wPartyCount]
jr nz, .skipToNewMonEntry jr nz, .addMonOffset
; if it's PARTY_TO_BOX
ld hl, wBoxMons ld hl, wBoxMons
ld bc, wBoxMon2 - wBoxMon1 ; $21 ld bc, wBoxMon2 - wBoxMon1 ; $21
ld a, [wNumInBox] ld a, [wNumInBox]
.skipToNewMonEntry .addMonOffset
dec a dec a
call AddNTimes call AddNTimes
.asm_f575 .findMonDataSrc
push hl push hl
ld e, l ld e, l
ld d, h ld d, h
@ -394,16 +397,16 @@ _MoveMon:
and a and a
ld hl, wBoxMons ld hl, wBoxMons
ld bc, wBoxMon2 - wBoxMon1 ; $21 ld bc, wBoxMon2 - wBoxMon1 ; $21
jr z, .asm_f591 jr z, .addMonOffset2
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
ld hl, wDayCareMon ld hl, wDayCareMon
jr z, .asm_f597 jr z, .copyMonData
ld hl, wPartyMons ld hl, wPartyMons
ld bc, wPartyMon2 - wPartyMon1 ; $2c ld bc, wPartyMon2 - wPartyMon1 ; $2c
.asm_f591 .addMonOffset2
ld a, [wWhichPokemon] ld a, [wWhichPokemon]
call AddNTimes call AddNTimes
.asm_f597 .copyMonData
push hl push hl
push de push de
ld bc, wBoxMon2 - wBoxMon1 ld bc, wBoxMon2 - wBoxMon1
@ -411,84 +414,85 @@ _MoveMon:
pop de pop de
pop hl pop hl
ld a, [wMoveMonType] ld a, [wMoveMonType]
and a and a ; BOX_TO_PARTY
jr z, .asm_f5b4 jr z, .findOTdest
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
jr z, .asm_f5b4 jr z, .findOTdest
ld bc, wBoxMon2 - wBoxMon1 ld bc, wBoxMon2 - wBoxMon1
add hl, bc add hl, bc
ld a, [hl] ld a, [hl] ; hl = Level
inc de inc de
inc de inc de
inc de inc de
ld [de], a ld [de], a ; de = BoxLevel
.asm_f5b4 .findOTdest
ld a, [wMoveMonType] ld a, [wMoveMonType]
cp PARTY_TO_DAYCARE cp PARTY_TO_DAYCARE
ld de, wDayCareMonOT ld de, wDayCareMonOT
jr z, .asm_f5d3 jr z, .findOTsrc
dec a dec a
ld hl, wPartyMonOT ld hl, wPartyMonOT
ld a, [wPartyCount] ld a, [wPartyCount]
jr nz, .asm_f5cd jr nz, .addOToffset
ld hl, wBoxMonOT ld hl, wBoxMonOT
ld a, [wNumInBox] ld a, [wNumInBox]
.asm_f5cd .addOToffset
dec a dec a
call SkipFixedLengthTextEntries call SkipFixedLengthTextEntries
ld d, h ld d, h
ld e, l ld e, l
.asm_f5d3 .findOTsrc
ld hl, wBoxMonOT ld hl, wBoxMonOT
ld a, [wMoveMonType] ld a, [wMoveMonType]
and a and a
jr z, .asm_f5e6 jr z, .addOToffset2
ld hl, wDayCareMonOT ld hl, wDayCareMonOT
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
jr z, .asm_f5ec jr z, .copyOT
ld hl, wPartyMonOT ld hl, wPartyMonOT
.asm_f5e6 .addOToffset2
ld a, [wWhichPokemon] ld a, [wWhichPokemon]
call SkipFixedLengthTextEntries call SkipFixedLengthTextEntries
.asm_f5ec .copyOT
ld bc, NAME_LENGTH ld bc, NAME_LENGTH
call CopyData call CopyData
ld a, [wMoveMonType] ld a, [wMoveMonType]
.findNickDest
cp PARTY_TO_DAYCARE cp PARTY_TO_DAYCARE
ld de, wDayCareMonName ld de, wDayCareMonName
jr z, .asm_f611 jr z, .findNickSrc
dec a dec a
ld hl, wPartyMonNicks ld hl, wPartyMonNicks
ld a, [wPartyCount] ld a, [wPartyCount]
jr nz, .asm_f60b jr nz, .addNickOffset
ld hl, wBoxMonNicks ld hl, wBoxMonNicks
ld a, [wNumInBox] ld a, [wNumInBox]
.asm_f60b .addNickOffset
dec a dec a
call SkipFixedLengthTextEntries call SkipFixedLengthTextEntries
ld d, h ld d, h
ld e, l ld e, l
.asm_f611 .findNickSrc
ld hl, wBoxMonNicks ld hl, wBoxMonNicks
ld a, [wMoveMonType] ld a, [wMoveMonType]
and a and a
jr z, .asm_f624 jr z, .addNickOffset2
ld hl, wDayCareMonName ld hl, wDayCareMonName
cp DAYCARE_TO_PARTY cp DAYCARE_TO_PARTY
jr z, .asm_f62a jr z, .copyNick
ld hl, wPartyMonNicks ld hl, wPartyMonNicks
.asm_f624 .addNickOffset2
ld a, [wWhichPokemon] ld a, [wWhichPokemon]
call SkipFixedLengthTextEntries call SkipFixedLengthTextEntries
.asm_f62a .copyNick
ld bc, NAME_LENGTH ld bc, NAME_LENGTH
call CopyData call CopyData
pop hl pop hl
ld a, [wMoveMonType] ld a, [wMoveMonType]
cp PARTY_TO_BOX cp PARTY_TO_BOX
jr z, .asm_f664 jr z, .done
cp PARTY_TO_DAYCARE cp PARTY_TO_DAYCARE
jr z, .asm_f664 jr z, .done
push hl push hl
srl a srl a
add $2 add $2
@ -507,6 +511,6 @@ _MoveMon:
add hl, bc add hl, bc
ld b, $1 ld b, $1
call CalcStats call CalcStats
.asm_f664 .done
and a and a
ret ret