Whoa, this one's been in the making for a while now. This one has been my attempt to fix as much as I could within a little over a month. Here's what I've got for you.
- Fixed a bug in Silph Gauntlet where the trainers would not see you unless you spoke to them
- Removed the unnecessary Gawarhed and Wugtrio static encounters. In what was once Gawarhed's place is a Rare Candy.
- Implemented a working ferry system (huge thanks to Red++) that allows travelling to Faraway Island and Citrine City with the right tickets. Currently both maps use a copy of the SS Anne, which may be revised later.
- Bittybat, Magnetite and Burgela have been removed to fix a Pokedex bug where entries wouldn't display correctly if the total number wasn't a multiple of 8.
- Fixed a bug where fishing up a Wiglett and Wugtrio would play the trainer battle and Champion battle themes respectively
- Restructured the Pokedex a little. Don't worry, Lickitung's still number 108!
- All references to betamon in the disassembly have had their names updated to match the new Ogasawara ones
- Removed Blastyke as a Game Corner prize, replacing it with Squeamata.
- Garnet Cavern is now properly listed as a dungeon map
- Fixed an issue where trying to leave Bill's House after entering the garden would put you back in the garden
- Moved Silph Gauntlet's Beauty down 1 floor to make the number of trainers on each floor more consistent
- Finished Gauntlet 6F except for the trainer text (PvK please help)
- Gavillain's stats updated to match KEP 1.4 on the Showdown server. It's now a Dragon/Electric type with less Ice coverage.
- Fixed Clefable's and Wigglytuff's starting movesets from an earlier commit
- Fixed an ABSOLUTELY HORRIBLE, EGREGIOUSLY FRUSTRATING BUG that caused the Pokedex's seen counter to rarely update. This is what caused this commit to be delayed for so long. No joke.
- New sprites, courtesy of Albatross, for Sylveon's back sprite, Alolan Marowak, Alolan Muk, Galarian Weezing and Magnezone!
- Fixed a bug preventing the trade for Haunter from being accessed.
Currently the move tutor is a little bit broken - the IDs are 1 above how they should be. Shell speculates that it's searching at the table starting from Kangaskhan due to the way the decrements shake up but it may just be making things more complicated than they are.
Big cheese code is `PrepareTradebackMoveList`, it's where things are mucking up.
Also, the code can be significantly optimised, as it's currently being adapted from the function above, `PrepareRelearnableMoveList`; It doesn't need to check levels, for example.
Note that the relearner functions properly, so use it as a reference. I may have removed something important.
Technically, we could have NO_MON as an entry which may make things shake out properly. But I'd rather have a proper fix.
