thorn/kep-hack
1
0
Fork 0
mirror of https://github.com/thornAvery/kep-hack.git synced 2026-02-06 23:55:24 +13:00
Code Issues Projects Releases Packages Wiki Activity Actions

lots of bug fixes

Browse source 
added a log for them in the readme
This commit is contained in:
May Evans 2022-08-31 15:18:16 +01:00
parent 7c6bbb630f
commit 648289d4a9
12 changed files with 61 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
engine/battle/animations.asm
View file

@ -1339,8 +1339,7 @@ AdjustOAMBlockYPos2:
add b
cp 112
jr c, .skipSettingPreviousEntrysAttribute
dec hl
ld a, 160 ; bug, sets previous OAM entry's attribute
ld a, 160 ; fixes the smoke puff bug - PvK
ld [hli], a
.skipSettingPreviousEntrysAttribute
ld [hl], a

2
engine/battle/core.asm
View file

@ -2375,6 +2375,8 @@ PartyMenuOrRockOrRun:
predef StatusScreen
predef StatusScreen2
; now we need to reload the enemy mon pic
ld a, 1
ldh [hWhoseTurn], a
ld a, [wEnemyBattleStatus2]
bit HAS_SUBSTITUTE_UP, a ; does the enemy mon have a substitute?
ld hl, AnimationSubstitute

4
engine/events/hidden_items.asm
View file

@ -77,7 +77,7 @@ HiddenCoins:
cp 20
jr z, .bcd20
cp 40
jr z, .bcd20 ; should be bcd40
jr z, .bcd40 ; fixes the 40 coin stash thing - PvK
jr .bcd100
.bcd10
ld a, $10
@ -87,7 +87,7 @@ HiddenCoins:
ld a, $20
ldh [hCoins + 1], a
jr .bcdDone
.bcd40 ; due to a typo, this is never used
.bcd40
ld a, $40
ldh [hCoins + 1], a
jr .bcdDone

6
engine/items/itemfinder.asm
View file

@ -27,7 +27,9 @@ HiddenItemNear:
ld a, [wYCoord]
call Sub5ClampTo0
cp d
jr z, .y_zflag ; starts to fix the y/x coord 0 no find bug - PvK
jr nc, .loop
y_zflag
ld a, [wYCoord]
add 4
cp d
@ -35,7 +37,9 @@ HiddenItemNear:
ld a, [wXCoord]
call Sub5ClampTo0
cp e
jr z, .x_zflag
jr nc, .loop
.x_zflag
ld a, [wXCoord]
add 5
cp e
@ -45,7 +49,7 @@ HiddenItemNear:
Sub5ClampTo0:
; subtract 5 but clamp to 0
sub 5
sub 4
cp $f0
ret c
xor a

4
engine/menus/naming_screen.asm
View file

@ -326,9 +326,7 @@ DisplayNamingScreen:
LoadEDTile:
ld de, ED_Tile
ld hl, vFont tile $70
ld bc, (ED_TileEnd - ED_Tile) / $8
; to fix the graphical bug on poor emulators
;lb bc, BANK(ED_Tile), (ED_TileEnd - ED_Tile) / $8
lb bc, BANK(ED_Tile), (ED_TileEnd - ED_Tile) / $8 ; bad emulators work fine w/ this
jp CopyVideoDataDouble
ED_Tile:

2
engine/movie/splash.asm
View file

@ -124,7 +124,7 @@ AnimateShootingStar:
ld a, [wMoveDownSmallStarsOAMCount]
cp 24
jr z, .next2
add 6 ; should be 4, but the extra 2 aren't visible on screen
add 4 ; fixes the invisible extra 2 stars that can take up ram
ld [wMoveDownSmallStarsOAMCount], a
.next2
call MoveDownSmallStars

2
engine/overworld/healing_machine.asm
View file

@ -1,7 +1,7 @@
AnimateHealingMachine:
ld de, PokeCenterFlashingMonitorAndHealBall
ld hl, vChars0 tile $7c
lb bc, BANK(PokeCenterFlashingMonitorAndHealBall), 3 ; should be 2
lb bc, BANK(PokeCenterFlashingMonitorAndHealBall), 2 ; fixed from 3 - PvK
call CopyVideoData
ld hl, wUpdateSpritesEnabled
ld a, [hl]

5
engine/overworld/player_animations.asm
View file

@ -88,6 +88,7 @@ PlayerSpinWhileMovingDown:
ld [hli], a ; wPlayerSpinWhileMovingUpOrDownAnimMaxY
call GetPlayerTeleportAnimFrameDelay
ld [hl], a ; wPlayerSpinWhileMovingUpOrDownAnimFrameDelay
ld hl, wFacingDirectionList ; this fixes the jp characters on dmg/sgb - PvK
jp PlayerSpinWhileMovingUpOrDown
_LeaveMapAnim::
@ -108,6 +109,7 @@ _LeaveMapAnim::
ld [hli], a ; wPlayerSpinWhileMovingUpOrDownAnimMaxY
call GetPlayerTeleportAnimFrameDelay
ld [hl], a ; wPlayerSpinWhileMovingUpOrDownAnimFrameDelay
ld hl, wFacingDirectionList ; this fixes the thing too - PvK
call PlayerSpinWhileMovingUpOrDown
call IsPlayerStandingOnWarpPadOrHole
ld a, b
@ -202,6 +204,9 @@ FlyAnimationScreenCoords2:
db $F0, $00
LeaveMapThroughHoleAnim:
ld a, [wLastMusicSoundID]
cp MUSIC_BIKE_RIDING
call z, PlayDefaultMusic ; this fixes the bike music persisting - PvK
ld a, $ff
ld [wUpdateSpritesEnabled], a ; disable UpdateSprites
; shift upper half of player's sprite down 8 pixels and hide lower half

12
engine/slots/slot_machine.asm
View file

@ -304,7 +304,7 @@ SlotMachine_StopWheel1Early:
.loop
ld a, [hli]
cp HIGH(SLOTS7)
jr c, .stopWheel ; condition never true
jr z, .stopWheel ; now works properly - PvK
dec c
jr nz, .loop
ret
@ -329,9 +329,13 @@ SlotMachine_StopWheel2Early:
; player's odds.
.sevenAndBarMode
call SlotMachine_FindWheel1Wheel2Matches
ret nz
ld a, [de]
cp HIGH(SLOTSBAR) + 1
ret nc
jr c, .stopWheel
ld a, [wSlotMachineFlags]
bit 6, a
ret z
.stopWheel
xor a
ld [wSlotMachineWheel2SlipCounter], a
@ -850,7 +854,7 @@ LoadSlotMachineTiles:
call DisableLCD
ld hl, SlotMachineTiles2
ld de, vChars0
ld bc, $1c tiles ; should be SlotMachineTiles2End - SlotMachineTiles2, or $18 tiles
ld bc, SlotMachineTiles2End - SlotMachineTiles2 ; fixes loading too many tiles - PvK
ld a, BANK(SlotMachineTiles2)
call FarCopyData2
ld hl, SlotMachineTiles1
@ -860,7 +864,7 @@ LoadSlotMachineTiles:
call FarCopyData2
ld hl, SlotMachineTiles2
ld de, vChars2 tile $25
ld bc, $1c tiles ; should be SlotMachineTiles2End - SlotMachineTiles2, or $18 tiles
ld bc, SlotMachineTiles2End - SlotMachineTiles2
ld a, BANK(SlotMachineTiles2)
call FarCopyData2
ld hl, SlotMachineMap