mirror of
https://github.com/thornAvery/kep-hack.git
synced 2026-02-06 15:45:24 +13:00
more bug fixes
This commit is contained in:
parent
648289d4a9
commit
a216a0f2e7
7 changed files with 30 additions and 6 deletions
|
|
@ -780,6 +780,10 @@ FaintEnemyPokemon:
|
|||
hlcoord 0, 0
|
||||
lb bc, 4, 11
|
||||
call ClearScreenArea
|
||||
call AnyPartyAlive ; this fixes victory music playing at the wrong time ; PvK
|
||||
ld a, d
|
||||
and a
|
||||
push af
|
||||
ld a, [wIsInBattle]
|
||||
dec a
|
||||
jr z, .wild_win
|
||||
|
|
@ -798,11 +802,14 @@ FaintEnemyPokemon:
|
|||
jr .sfxplayed
|
||||
.wild_win
|
||||
call EndLowHealthAlarm
|
||||
pop af
|
||||
push af
|
||||
ld a, MUSIC_DEFEATED_WILD_MON
|
||||
call PlayBattleVictoryMusic
|
||||
call nz, PlayBattleVictoryMusic
|
||||
.sfxplayed
|
||||
; bug: win sfx is played for wild battles before checking for player mon HP
|
||||
; this can lead to odd scenarios where both player and enemy faint, as the win sfx plays yet the player never won the battle
|
||||
; kep fixes this - PvK
|
||||
ld hl, wBattleMonHP
|
||||
ld a, [hli]
|
||||
or [hl]
|
||||
|
|
@ -812,9 +819,7 @@ FaintEnemyPokemon:
|
|||
jr nz, .playermonnotfaint ; if so, don't call RemoveFaintedPlayerMon twice
|
||||
call RemoveFaintedPlayerMon
|
||||
.playermonnotfaint
|
||||
call AnyPartyAlive
|
||||
ld a, d
|
||||
and a
|
||||
pop af
|
||||
ret z
|
||||
ld hl, EnemyMonFaintedText
|
||||
call PrintText
|
||||
|
|
|
|||
|
|
@ -462,6 +462,9 @@ StartMenu_TrainerInfo::
|
|||
predef DrawBadges ; draw badges
|
||||
ld b, SET_PAL_TRAINER_CARD
|
||||
call RunPaletteCommand
|
||||
ld a, [wOnSGB] ; this fixes garbage on dmgs
|
||||
and a
|
||||
call z, Delay3
|
||||
call GBPalNormal
|
||||
call WaitForTextScrollButtonPress ; wait for button press
|
||||
call GBPalWhiteOut
|
||||
|
|
@ -469,6 +472,9 @@ StartMenu_TrainerInfo::
|
|||
call LoadScreenTilesFromBuffer2 ; restore saved screen
|
||||
call RunDefaultPaletteCommand
|
||||
call ReloadMapData
|
||||
ld a, [wOnSGB] ; this fixes garbage on dmgs
|
||||
and a
|
||||
call z, Delay3
|
||||
call LoadGBPal
|
||||
pop af
|
||||
ldh [hTileAnimations], a
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue