Commit graph

65 commits

Author SHA1 Message Date
dannye 218993bd19 Fix sound reset in PlayBattleMusic
the id check bandaid in _PlayMusic is no longer necessary
2021-04-11 12:14:22 -05:00
dannye 5eff10358e Merge branch 'master' of https://github.com/pret/pokered 2021-04-10 22:38:40 -05:00
Rangi 2954013da1 Trim extra newlines from some files 2021-04-08 12:51:25 -04:00
dannye b2afaae7ab Fix remaining uses of fade 2021-03-30 01:06:32 -05:00
dannye 37d3ba4b39 Fix alternate starts/tempos 2021-03-29 22:30:01 -05:00
dannye 3508dc8e1d Remove last few red audio variables 2021-03-29 00:42:28 -05:00
dannye c1278c478e Fix pokeflute in battle sfx
and other small improvements
2021-03-28 23:23:45 -05:00
dannye 459b5bd615 Misc clean up and small improvements 2021-03-28 02:23:54 -05:00
Rangi 95ec2cf039 Verify data table and name list sizes with assertion macros
Fixes #312
2021-03-25 16:44:41 -04:00
dannye e8dd755e18 Merge branch 'master' of https://github.com/pret/pokered 2021-03-23 01:19:51 -05:00
SatoMew 6989cdb8c6 And extend this principle to the filename as well 2020-11-30 21:17:38 +00:00
SatoMew f99446fccb Be consistent with the unused and unreferenced terminology 2020-11-30 20:09:51 +00:00
SatoMew 330fa33236 Rename the unreferenced fanfare's constants 2020-11-30 01:39:49 +00:00
SatoMew a7dca30971 Identify what became GSC's Key Item fanfare 2020-11-29 21:10:36 +00:00
dannye 66377fca32 Fix file modes 2020-11-14 20:52:10 -06:00
Rangi 76289dfda0 Port dbsprite macro for OAM y,x,tile,attr data from pokecrystal 2020-07-17 15:58:06 -04:00
Rangi 30ecbf6ea3 SONY -> RIVAL 2020-07-17 13:27:27 -04:00
Rangi 7306c1dc2d Define constants for audio commands 2020-07-16 13:25:02 -04:00
Rangi f37cf959c9 Clean up some data, using macros for multiline list entries 2020-07-14 13:32:09 -04:00
Rangi 772fcc7588 Specify the ldh instruction, don't turn ld into ldh 2020-07-06 19:03:05 -04:00
Rangi 6ef36800b0 Replace raw hex values with HRAM constants
To do: turn constants into labels and use ldh
2020-07-03 22:22:09 -04:00
Rangi 9878f01e29 Organize macros/ like pokecrystal
While doing so I replaced the StopAllMusic macro with a SFX_STOP_ALL_MUSIC constant and applied it throughout the code.
2020-07-03 16:37:47 -04:00
Rangi 91dc3c9f9c Remove unused Yellow music 2020-07-03 11:52:16 -04:00
Rangi f275790aec Add subdirectories to engine/ similar to pokecrystal 2020-07-02 23:30:21 -04:00
Rangi 2d562a673b Factor out shared audio/notes.asm 2020-06-27 22:24:13 -04:00
dannye 362bba7642 Rename dnote to drum_note and dspeed to drum_speed 2019-09-03 22:36:02 -05:00
dannye 44b9a240d4 Make pitch_sweep pitch change argument consistent with the other signed magnitude arguments 2019-08-25 09:57:50 -05:00
dannye 8b0cd72a60 Finish cleaning up audio macro arguments and descriptions
break up arguments for stereo_panning and duty_cycle_pattern
note_type fade is signed
properly document arguments for vibrato, tempo, pitch_slide etc
2019-08-18 21:43:15 -05:00
dannye 969b43d443 Update labels to match new audio macro names
and synchronize engine_2 and engine_3 with engine_1
2019-08-17 14:47:16 -05:00
dannye 6574881cda Use generic names for noise instruments
coming up with satisfactory names is hard, besides this will improve compatibility with crystal
2019-07-28 17:29:35 -05:00
dannye 20c4116788 Update audio macro names
change audio channel numbers from 0-7 back to 1-8
change all note macros back to single note macro
todo: fix comments with old macro names, update noise macros/instrument names
2019-07-27 23:21:39 -05:00
dannye 970a86ea91 Merge commit '32c371b1d3bf5650fa77ada4bc15be6bcce9ea59' 2019-04-13 17:02:04 -05:00
SatoMew df2a68d6de Replace the few instances of Unknown Dungeon with Cerulean Cave 2019-04-08 18:47:31 +01:00
dannye 4398dde1e4 Break up sfxnote parameters into duty, volume, volume change and pitch 2018-03-16 20:35:40 -05:00
dannye b382473f7b Break up pitchenvelope parameters into length and pitch change 2018-03-16 18:07:41 -05:00
Eggy0 5826f25bef Made some changes 2018-03-16 22:02:14 +01:00
dannye 87eed68710 Insert Crystal audio engine and music
most credit goes to Sanqui
2017-05-07 15:30:08 -05:00
dannye 52bb07ca18 Replace unnecessary tabs with spaces 2016-07-27 22:33:48 -05:00
dannye 5207a14af3 Redo audio header macro 2016-07-27 22:08:13 -05:00
dannye dbe2a3b168 Add warnings about music/sfx macro usage
These are not game limitations, just restrictions for
the macros to behave properly
2016-07-27 20:57:46 -05:00
dannye 4992ae2233 Macros to automate music and sound effect headers 2016-07-27 20:21:56 -05:00
dannye 9984527c2c Fix music channel numbering
same as previous, but for songs instead of sound effects
2016-07-27 20:19:59 -05:00
dannye 84c7985e67 Fix sound effect channel numbering
mostly so that sound effects that only use the noise channel are
labelled 'Ch7' instead of 'Ch1'
2016-07-27 19:30:57 -05:00
dannye a51037eeee Remove the last address comments
except for wram.asm and sram.asm
also delete unused yellow file
2016-06-12 02:19:44 -05:00
YamaArashi 7f34e28f24 remove address comments 2016-06-11 17:24:04 -07:00
YamaArashi 2b01815999 commented audio code 2015-08-08 22:32:44 -07:00
dannye a6f04b4349 Unify audio bank references
2→1
8→2
1f→3
2015-07-22 10:22:46 -05:00
dannye b4081e851a Rename sound effect files 2015-07-22 09:57:31 -05:00
U-Daniel-PC\Daniel 80621d3731 Rename/organize part 4 of 4
rename functions, clean up address/wram comments, other misc
only broken up so that all changes are viewable on github
2015-07-03 14:39:40 -05:00
U-Daniel-PC\Daniel fc9b61e8ac Rename/organize part 3 of 4
rename functions, clean up address/wram comments, other misc
only broken up so that all changes are viewable on github
2015-07-03 14:39:24 -05:00